Attention is currently required from: Jonathan Zhang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48946 )
Change subject: mb/ocp/deltalake: Override DDR frequency limit via VPD variable ......................................................................
Patch Set 9:
(4 comments)
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/48946/comment/d0cfaf8f_44d40b02 PS9, Line 82: ddr_freq_limit DdrFreqLimit(int num) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/48946/comment/80dd059c_2c590db0 PS9, Line 103: printk(BIOS_WARNING, "Invalid DdrFreqLimit value from VPD: " Prefer using '"%s...", __func__' to using 'DdrFreqLimit', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/48946/comment/17de4c40_6983db1e PS9, Line 111: printk(BIOS_INFO, "Setting DdrFreqLimit %d from VPD\n", val_int); Prefer using '"%s...", __func__' to using 'DdrFreqLimit', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/48946/comment/b63c448b_0cd3f20b PS9, Line 115: "DdrFreqLimit to %d\n", FSP_DIMM_FREQ, Prefer using '"%s...", __func__' to using 'DdrFreqLimit', this function's name, in a string