build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41750 ) Change subject: spi/macronix: Add support for boot media protection ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/c/coreboot/+/41750/1/src/drivers/spi/macronix.c File src/drivers/spi/macronix.c: https://review.coreboot.org/c/coreboot/+/41750/1/src/drivers/spi/macronix.c@... PS1, Line 197: } else { else is not generally useful after a break or return https://review.coreboot.org/c/coreboot/+/41750/1/src/drivers/spi/macronix.c@... PS1, Line 212: } else { else is not generally useful after a break or return -- To view, visit https://review.coreboot.org/c/coreboot/+/41750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb92ba9f92746f8c7886220b31d86c130f906c6d Gerrit-Change-Number: 41750 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gröber (dxld) Gerrit-Reviewer: Daniel Gröber <dxld@darkboxed.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 26 May 2020 21:44:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment