Attention is currently required from: Appukuttan V K, Ronak Kanabar.
Subrata Banik has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82425?usp=email )
Change subject: vc/edk2-stable202302: Add config guards to support FSP 2.4 ......................................................................
Patch Set 23:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82425/comment/d155b708_9ca1ec7b?usp... : PS23, Line 16: - Guard x86_32 architecture specific structures under : PLATFORM_USES_FSP2_X86_32 config. : - Guard FSP 2.4 specific structures under PLATFORM_USES_FSP2_4 : config.
I guess the problem that we are using FSP2.3 for x32 and FSP2.4 for x64. If both are using 2. […]
I don't think so, we are not building both code at same time. We are building 32-bit and 64-bit in separate build in that case why it would throw build fail.
btw, what build failure we are seeing w/o this CPP guarding ?
File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h:
https://review.coreboot.org/c/coreboot/+/82425/comment/3ea016b4_b027305c?usp... : PS23, Line 382: } FSPT_UPD_COMMON_FSP24;
FSPT is not used anywhere so it is not causing any issue. Do you want to guard this anyway.
yes. there are more coreboot users than just cros team alone.