Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78794?usp=email )
Change subject: mb/google/rex: Avoid hang for pre-prod SoC by setting SAGV_POINTS_0_1_2 ......................................................................
mb/google/rex: Avoid hang for pre-prod SoC by setting SAGV_POINTS_0_1_2
Intel has identified an idle hang issue on pre-prod silicon that will not be fixed or root-caused. To avoid the issue, this commit sets SaGvWpMask to SAGV_POINTS_0_1_2 in the devicetree.
Note: This change will affect system power.
BUG=b:287170545 TEST=Able to idle for more than 5+ hours without any hang on google/screebo.
Change-Id: Id0b8db0076d983d336c3bec6d6c33614c69964d1 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/78794 Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb M src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb 2 files changed, 4 insertions(+), 0 deletions(-)
Approvals: Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb index 0835ded..7358eeb 100644 --- a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb +++ b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb @@ -52,6 +52,8 @@ register "cnvi_bt_core" = "true"
register "sagv" = "SAGV_ENABLED" + # TODO(b/287170545): workaround avoid DUT random hang + register "sagv_wp_bitmap" = "SAGV_POINTS_0_1_2"
register "sagv_freq_mhz[0]" = "3200" register "sagv_gear[0]" = "4" diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb index 5894fe6..625a36b 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb +++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb @@ -49,6 +49,8 @@ register "cnvi_bt_core" = "true"
register "sagv" = "SAGV_ENABLED" + # TODO(b/287170545): workaround avoid DUT random hang + register "sagv_wp_bitmap" = "SAGV_POINTS_0_1_2"
register "sagv_freq_mhz[0]" = "3200" register "sagv_gear[0]" = "4"