Attention is currently required from: Michał Żygowski, Michał Kopeć.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68944 )
Change subject: soc/intel/common/block/oc_wdt: Add OC watchdog common block
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/oc_wdt/Kconfig:
https://review.coreboot.org/c/coreboot/+/68944/comment/eb552264_a3dfc0d7
PS7, Line 10: HAVE_CF9_RESET_PREPARE
This seems wrong to me. The HAVE_ options in Kconfig are typically set by the mainboard or SOC to say that they support a certain feature. Typically these are not user selectable, and are used as 'depends on' values.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68944
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib494aa0c7581351abca8b496fc5895b2c7cbc5bc
Gerrit-Change-Number: 68944
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Thu, 24 Nov 2022 06:22:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment