Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30844 )
Change subject: string.h: allow to compile strdup in romstage
......................................................................
Patch Set 5:
https://qa.coreboot.org/job/coreboot-gerrit/87667/ : UNSTABLE
It seems everyone has its own ASSERT() defined. I see two ways
to fix it (both not in the scope of this change).
1. don't define ASSERT() in assert.h (e.g. rename it to _ASSERT()). existing calls should call the standard assert()
2. move dead_code() into its own header file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85738a7c7c2f4b0be9b1624b34c478ecdfbb25ed
Gerrit-Change-Number: 30844
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sat, 19 Jan 2019 15:40:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment