Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36462 )
Change subject: soc/intel/{cnl,icl,skl}: Remove unused SMI opregion
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36462/1/src/soc/intel/skylake/acpi/...
File src/soc/intel/skylake/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/36462/1/src/soc/intel/skylake/acpi/...
PS1, Line 38: /* IO-Trap at 0x800.
: * This is the ACPI->SMI communication interface.
: */
: OperationRegion (IO_T, SystemIO, 0x800, 0x10)
: Field (IO_T, ByteAcc, NoLock, Preserve)
: {
: Offset (0x8),
: TRP0, 8 /* IO-Trap at 0x808 */
: }
yes should be good to clean as well
Done https://review.coreboot.org/c/coreboot/+/36466
https://review.coreboot.org/c/coreboot/+/36462/1/src/soc/intel/skylake/acpi/...
PS1, Line 49: TRAP
may be i will check with GFX team if they have any question, but in general good to clean both in sp […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d63c005873fc5d67b4a44f42bb436628d7c1dc3
Gerrit-Change-Number: 36462
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Oct 2019 12:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment