Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 )
Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/board_info.txt:
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 3: Board serial: DAOX33MBAFO I think this is board specific and should be removed.
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 43: Remove empty line
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/gpio.h:
PS10: Please get everything aligned and use a style like this:
/* GPIO_PIN */ _PAD_CFG_STRUCT(..., ..., ...)