Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37738 )
Change subject: southbridge/amd: deduplicate MMIO macro [WIP] ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37738/1/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37738/1/src/mainboard/asus/f2a85-m/... PS1, Line 35: SB_MMIO_MISC32(0x28) = reg32; Looks like <amdblocks/acpimmio.h> misc_read/write32().
We should do bulk commit tree-wide, let's wait if Michal already has something on this one too, there is similar work for 0xcd6/0cd7.