Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32666 )
Change subject: mediatek/mt8183: Add md power off flow
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
just some nits.
@jwerner I think this seems ok. Time to take a final review?
https://review.coreboot.org/#/c/32666/7/src/soc/mediatek/mt8183/md_ctrl.c
File src/soc/mediatek/mt8183/md_ctrl.c:
https://review.coreboot.org/#/c/32666/7/src/soc/mediatek/mt8183/md_ctrl.c@28
PS7, Line 28: (
no need to quote since this is one single arg.
TOPCKGEN_CLK ... | TOPCKGEN...);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32666
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6e11faeb6936a1dd6bbe8b1a8b612446bf51082
Gerrit-Change-Number: 32666
Gerrit-PatchSet: 7
Gerrit-Owner: Yanjie Jiang
yanjie.jiang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Yanjie Jiang
yanjie.jiang@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Jun 2019 03:52:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment