23 Dec
2020
23 Dec
'20
12:36 p.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48862 )
Change subject: drivers/intel/gma: Rework brightness level includes ......................................................................
Patch Set 1:
Patch Set 1:
Why not rename `gma.asl` to `gma_with_panel.asl` or something like that? Then add one without the panel boilerplate for desktops etc. It would a) reduce unwanted boilerplate further and b) not need repeated includes in the mainboards.
I'm perfectly happy to do it that way as well
--
To view, visit https://review.coreboot.org/c/coreboot/+/48862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie71bd5fc7acd926b7ce7da17fbc108670fd453e0
Gerrit-Change-Number: 48862
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Dec 2020 20:36:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment