Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29813 )
Change subject: util/lint: Allow non-option carrying named choices
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/29813/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/29813/1//COMMIT_MSG@23
PS1, Line 23: endif
It's usually the other way around: 1. the board predefines the option with […]
I'd guess it could work as long as the board code is the first
to specify a default.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29813
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6662e19685f6ab0b84c78b30aedc266c0e176039
Gerrit-Change-Number: 29813
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 19 Feb 2020 13:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment