Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40351 )
Change subject: mb/dell/optiplex_9010: Add Dell OptiPlex 9010 SFF support ......................................................................
Patch Set 10:
(13 comments)
https://review.coreboot.org/c/coreboot/+/40351/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40351/10//COMMIT_MSG@8 PS10, Line 8: Add a note, that the other chassis variants could be added as variants?
Did you use autoport in any way?
https://review.coreboot.org/c/coreboot/+/40351/5/src/mainboard/dell/optiplex... File src/mainboard/dell/optiplex_9010/gpio.c:
https://review.coreboot.org/c/coreboot/+/40351/5/src/mainboard/dell/optiplex... PS5, Line 98: .gpio39 = GPIO_MODE_GPIO, /* FP_PRES# */
'PRES' may be misspelled - perhaps 'PRESS'?
Done
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_9010/romstage.c:
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 23: (about 3-5 seconds) Replace *few*, and put that in the beginning
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 25: , Remove.
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_9010/sch5545_ec.c:
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 513: uint8_t rw_bit) One line?
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 571: printk(BIOS_ERR, "The fans will keep running at maximum speed\n"); Dot/period at the end please.
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 576: Log/print the firmware version.
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 605: make makes
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 611: printk(BIOS_INFO, "SCH5545 EC firmware up to date\n"); Print the firmware version?
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 694: ec_hwm_sequence[i].tdp == TDP_COMMON) { One line?
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 752: chassis_type); One lline.
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 756: ARRAY_SIZE(ec_hwm_chassis3)); One line?
https://review.coreboot.org/c/coreboot/+/40351/10/src/mainboard/dell/optiple... PS10, Line 784: setup set up