Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32407 )
Change subject: soc/amd/picasso: Create picasso as a copy of stoneyridge ......................................................................
Patch Set 3:
(6 comments)
THe idea is that this change is an identical copy of stoneyridge. Follow-up changes then correct everything that differs, so that one can see the difference between stoney and picasso.
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/Kconfig@16 PS3, Line 16: STONEYRIDGE
looks like it is intentional
Indeed.
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/chip.c File src/soc/amd/picasso/chip.c:
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/chip.c@17 PS3, Line 17: include <console/console.h>
if I'm not wrong, this is not used
It is used. See the end of this file, which makes use of the function: void post_code(u8 value);
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/chip.c@35 PS3, Line 35: stoneyridge
is it intentional?
Yes, see recent change log messages, as well as Patchset 2.
This applies to all the comments about "stoney" being in this patch.
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/enable_usbdebug.... File src/soc/amd/picasso/enable_usbdebug.c:
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/enable_usbdebug.... PS3, Line 22: <device/pci_def.h
maybe not used?
Looks like it. Should be fixed on stoneyridge as well.
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/include/soc/nvs.... File src/soc/amd/picasso/include/soc/nvs.h:
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/include/soc/nvs.... PS3, Line 20: stoneyridge
is it intentional?
Yes.
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/tsc_freq.c File src/soc/amd/picasso/tsc_freq.c:
https://review.coreboot.org/#/c/32407/3/src/soc/amd/picasso/tsc_freq.c@33 PS3, Line 33: Family 15h Models 70h-7Fh
17h ?
The code still needs to be changed to work for picasso chips.