Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31187 )
Change subject: mb/lenovo/x200/gpio.c: Unclutter the code
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks good, but I only took a quick look.
https://review.coreboot.org/#/c/31187/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31187/1//COMMIT_MSG@10
PS1, Line 10: direction
direction? maybe you mean high/low levels?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib37837b9cdb8bb05e2523e0c43cc71fe4fbf243b
Gerrit-Change-Number: 31187
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 03 Feb 2019 18:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment