Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37778 )
Change subject: ec/hp/kbc1126: Make firmware offsets user configurable ......................................................................
ec/hp/kbc1126: Make firmware offsets user configurable
After C_ENVIRONMENT_BOOTBLOCK became mainstream, coreboot build system starts to produce larger bootblock, conflicting with former default offsets.
This change makes these offsets configurable before building, with default values lower than before, to better fit the larger bootblock.
Change-Id: Ie022663a4d0df7f431865b55f7329a9ebb90863b Signed-off-by: Bill XIE persmule@hardenedlinux.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/37778 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/hp/kbc1126/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/ec/hp/kbc1126/Kconfig b/src/ec/hp/kbc1126/Kconfig index 4ed7dd5..eb6bd90 100644 --- a/src/ec/hp/kbc1126/Kconfig +++ b/src/ec/hp/kbc1126/Kconfig @@ -40,9 +40,9 @@ vendor firmware.
config KBC1126_FW1_OFFSET - string + string "Offset of KBC1126 firmware #1" depends on KBC1126_FIRMWARE - default "0xffff8000" + default "0xfffe8000"
config KBC1126_FW2 string "KBC1126 filename #2 path and filename" @@ -54,8 +54,8 @@ vendor firmware.
config KBC1126_FW2_OFFSET - string + string "Offset of KBC1126 firmware #2" depends on KBC1126_FIRMWARE - default "0xfffe0000" + default "0xfffd0000"
endif