[coreboot-gerrit] [L] Change in coreboot[master]: [WIP] sb,soc/intel/common: Add common get_pmbase()

[Werner Zeh (Code Review)]

Attention is currently required from: Jeff Daly, Jonathan Zhang, Angel Pons, Arthur Heymans, Kyösti Mälkki, Tarun Tuli, Sean Rhodes, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Tim Chu.

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70048 )

Change subject: [WIP] sb,soc/intel/common: Add common get_pmbase()
......................................................................

Patch Set 4:

(9 comments)

File src/soc/intel/apollolake/acpi.c:

https://review.coreboot.org/c/coreboot/+/70048/comment/b8e09d2d_7bdbcf73 
PS4, Line 80:  
There was a patch recently removing all the spaces after type casts.

https://review.coreboot.org/c/coreboot/+/70048/comment/9809d6d8_e825ac3f 
PS4, Line 219:  
same here

https://review.coreboot.org/c/coreboot/+/70048/comment/1681fd97_52e58df6 
PS4, Line 243:  
same here

File src/soc/intel/braswell/pmutil.c:

https://review.coreboot.org/c/coreboot/+/70048/comment/fa57011f_a7473380 
PS4, Line 14: include <security/vboot/vbnv.h>
Once you start sorting the includes in this patch you could move console/console.h, too.

File src/soc/intel/broadwell/pch/pmutil.c:

https://review.coreboot.org/c/coreboot/+/70048/comment/04ede38d_1b8b6376 
PS4, Line 15: #include <console/console.h>
Move this line in the right order as well?

File src/soc/intel/skylake/pmutil.c:

https://review.coreboot.org/c/coreboot/+/70048/comment/0a0e7a06_e4870643 
PS4, Line 139:  
extra space

https://review.coreboot.org/c/coreboot/+/70048/comment/78e80630_8a181ffc 
PS4, Line 144:  
extra space

File src/soc/intel/xeon_sp/pmutil.c:

https://review.coreboot.org/c/coreboot/+/70048/comment/ce5cc877_eb9838eb 
PS4, Line 95:  
extra space

https://review.coreboot.org/c/coreboot/+/70048/comment/ef000d0d_a6c4a906 
PS4, Line 100:  
extra space