[coreboot-gerrit] Change in coreboot[master]: AGESA,binaryPI: Remove BIST reporting in romstage

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37348 )

Change subject: AGESA,binaryPI: Remove BIST reporting in romstage
......................................................................

AGESA,binaryPI: Remove BIST reporting in romstage

For easier C environment bootblock transition by using
already existing prototypes, BIST will not be passed
to romstage. It is expected that bootblock will have
equivalent code.

Change-Id: I0f8e3657ac79277cd77c397d1b3e931e33a6f5db
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37348
Reviewed-by: Angel Pons 
Reviewed-by: Arthur Heymans 
Reviewed-by: Michał Żygowski 
Tested-by: build bot (Jenkins) 
---
M src/drivers/amd/agesa/romstage.c
1 file changed, 4 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Angel Pons: Looks good to me, approved
  Michał Żygowski: Looks good to me, approved

diff --git a/src/drivers/amd/agesa/romstage.c b/src/drivers/amd/agesa/romstage.c
index f9a8c97..8460035 100644
--- a/src/drivers/amd/agesa/romstage.c
+++ b/src/drivers/amd/agesa/romstage.c
@@ -16,7 +16,6 @@
 #include <arch/romstage.h>
 #include <cbmem.h>
 #include <cpu/amd/car.h>
-#include <cpu/x86/bist.h>
 #include <console/console.h>
 #include <halt.h>
 #include <program_loading.h>
@@ -40,7 +39,7 @@
    agesa_set_interface(cb);
 }

-static void bsp_romstage_main(unsigned long bist)
+static void bsp_romstage_main(void)
 {
    struct postcar_frame pcf;
    struct sysinfo romstage_state;
@@ -66,9 +65,6 @@
    printk(BIOS_DEBUG, "APIC %02d: CPU Family_Model = %08x\n",
    	initial_apic_id, cpuid_eax(1));

-	/* Halt if there was a built in self test failure */
-	report_bist_failure(bist);
-
    agesa_execute_state(cb, AMD_INIT_RESET);

agesa_execute_state(cb, AMD_INIT_EARLY);
@@ -103,7 +99,7 @@
    /* We do not return. */
 }

-static void __noreturn ap_romstage_main(unsigned long bist)
+static void __noreturn ap_romstage_main(void)
 {
    struct sysinfo romstage_state;
    struct sysinfo *cb = &romstage_state;
@@ -113,9 +109,6 @@

fill_sysinfo(cb);

-	/* Halt if there was a built in self test failure */
-	report_bist_failure(bist);
-
    agesa_execute_state(cb, AMD_INIT_RESET);

agesa_execute_state(cb, AMD_INIT_EARLY);
@@ -127,7 +120,7 @@
 asmlinkage void romstage_main(unsigned long bist)
 {
    if (boot_cpu())
-		bsp_romstage_main(bist);
+		bsp_romstage_main();
    else
-		ap_romstage_main(bist);
+		ap_romstage_main();
 }