12 Oct
2020
12 Oct
'20
10:23 p.m.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45911 )
Change subject: drivers/i2c: Add chip driver for GPIO based I2C multiplexer ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45911/5/src/drivers/i2c/gpio_mux/gp... File src/drivers/i2c/gpio_mux/gpio_mux.c:
https://review.coreboot.org/c/coreboot/+/45911/5/src/drivers/i2c/gpio_mux/gp... PS5, Line 108: dev->ops = &i2c_gpio_mux_ops;
I see that Tim has commented about having 2 separate chip drivers. […]
The drivers are split and the device operations are split accordingly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45911
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib371108cc6043c133681066bf7bf4b2e00771e8b
Gerrit-Change-Number: 45911
Gerrit-PatchSet: 7
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Evan Green evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Oct 2020 20:23:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment