Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Andrey Petrov, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50916 )
Change subject: soc/intel/apollolake: Add `GPE0_STS_BIT` macro
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/apollolake/include/soc/pm.h:
https://review.coreboot.org/c/coreboot/+/50916/comment/eba673c1_9aa61b73
PS1, Line 111: GPE0_STS_BIT
Good point. How would you word such a comment? I'm not too inspired today...
Not the best at it, but I can give it a try :P:
```
/*
* Datasheet says this bit is reserved. However, `southbridge_smi_handler` uses
* GPE0_STS_BIT to ignore GPE0-related SMI events in SCI mode (CB:50750). Though the
* bit is reserved for APL/GLK, use of this bit in `southbridge_smi_handler` does not
* cause any side-effects as the function just masks out this bit in the value read
* from SMI_STS register. Do not use this bit in any other common code as it can have
* undefined value for ALK/GLK.
*/
```
And obviously, it is very easy to still miss out on the comment :).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50916
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4408e016ba29cf8f7b125c95bfa668136b9eb93
Gerrit-Change-Number: 50916
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 19 Feb 2021 16:10:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment