Attention is currently required from: Julius Werner, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43510 )
Change subject: tests: Add lib/bootmem-test test case ......................................................................
Patch Set 7:
(4 comments)
File tests/lib/bootmem-test.c:
https://review.coreboot.org/c/coreboot/+/43510/comment/e7f1d6ab_e023d6fe PS6, Line 9: #define assert(statement) mock_assert(statement, #statement, __FILE__, __LINE__)
(Sorry for holding this patch up again but you added yet another new thing that requires discussion […]
Don't worry about holding this patch. It's better to submit a good one later than a problematic one right now. :)
Your idea looks great. I will divide it into two changes: - Add __TEST__ and ENV_TEST - Adapt assert.h to use mock_assert instead of default assert for ENV_TEST targets
Regarding ENV_TEST: I think that structure similar to ENV_TIMELESS definition will be sufficient.
Please see: https://review.coreboot.org/c/coreboot/+/51803 https://review.coreboot.org/c/coreboot/+/51804
https://review.coreboot.org/c/coreboot/+/43510/comment/d77273ef_ddbbb020 PS6, Line 13: #include <string.h>
nit: alphabetize?
Done
https://review.coreboot.org/c/coreboot/+/43510/comment/1645e0b0_b408d95a PS6, Line 167: assert_memory_equal(sentinel_value_buffer,
nit: I've seen this construct (malloc() and memset() something just to compare it) in a couple of te […]
I will have that in my mind. TODO as next patch :)
https://review.coreboot.org/c/coreboot/+/43510/comment/70712484_eb59d2dc PS6, Line 381: 0xE0000000
0xF0000000
Done