Attention is currently required from: Julius Werner, Jan Dabros.
4 comments:
File tests/lib/bootmem-test.c:
Patch Set #6, Line 9: #define assert(statement) mock_assert(statement, #statement, __FILE__, __LINE__)
(Sorry for holding this patch up again but you added yet another new thing that requires discussion […]
Don't worry about holding this patch. It's better to submit a good one later than a problematic one right now. :)
Your idea looks great. I will divide it into two changes:
Regarding ENV_TEST: I think that structure similar to ENV_TIMELESS definition will be sufficient.
Please see:
https://review.coreboot.org/c/coreboot/+/51803
https://review.coreboot.org/c/coreboot/+/51804
Patch Set #6, Line 13: #include <string.h>
nit: alphabetize?
Done
Patch Set #6, Line 167: assert_memory_equal(sentinel_value_buffer,
nit: I've seen this construct (malloc() and memset() something just to compare it) in a couple of te […]
I will have that in my mind. TODO as next patch :)
Patch Set #6, Line 381: 0xE0000000
0xF0000000
Done
To view, visit change 43510. To unsubscribe, or for help writing mail filters, visit settings.