Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35551/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35551/1//COMMIT_MSG@7 PS1, Line 7: support elan touchpad for Please update the commit message to reflect what really the change is.
https://review.coreboot.org/c/coreboot/+/35551/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35551/1/src/mainboard/google/hatch/... PS1, Line 67: ACPI_IRQ_EDGE_LOW This should be ACPI_IRQ_WAKE_EDGE_LOW if you have to support wake from touchpad.
https://review.coreboot.org/c/coreboot/+/35551/1/src/mainboard/google/hatch/... PS1, Line 75: ACPI_IRQ_EDGE_LOW Same here.