Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45270 )
Change subject: xeon_sp: Update skx pci_irq.asl for ACPI2.0 notation
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45270/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45270/1//COMMIT_MSG@13
PS1, Line 13: BUILD_TIMLESS
nit: tim*e*less
I would also mention which board you used to test this. Of course, I wouldn't expect this commit to change the old i440bx boards 😄
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a...
File src/soc/intel/xeon_sp/skx/acpi/pci_irq.asl:
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a...
PS1, Line 61: Store
oops, this one also :)
We can change these after the files are merged. Is that OK for you?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id44138894d2ffed4c93afe5d4bbb4d59b538b577
Gerrit-Change-Number: 45270
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 11 Sep 2020 09:21:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment