Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42311 )
Change subject: tests: Complete lib/string-test test case ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@a10 PS1, Line 10: One can use __builtin_xxx for many of the most simple str*() : * functions, when non-coreboot one is required.
Not sure why you're removing this? I think it's still useful advice...
Actually this comment is dangerous a little bit. Most of calls to the __builtin_*() functions (e.g. __builtin_strspn()), generates simple call to C library (e.g. strspn()) in the output object file. After linkage, this ends up as a call to the UUT. __builtin_strlen() is working OK, since compiler is optimizing this, by inserting constant value. Considering above, I agree that we should remove this line (optionally add a comment to keep using only __builtin_strlen() throughout the module).