1 Dec
2019
1 Dec
'19
6:35 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37258 )
Change subject: Add compatibility mode ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/em100/+/37258/3/image.c File image.c:
https://review.coreboot.org/c/em100/+/37258/3/image.c@92 PS3, Line 92: 0xff) << 4
It seems the functions are somewhat self-explanatory, given the only thing they do is extract the fu […]
I think the comment added on the last patchset is good enough
https://review.coreboot.org/c/em100/+/37258/4/image.c File image.c:
https://review.coreboot.org/c/em100/+/37258/4/image.c@182 PS4, Line 182: 17MHz 20MHz?
--
To view, visit https://review.coreboot.org/c/em100/+/37258
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Ie02264facb028841d18ed84680ffa40f45987510
Gerrit-Change-Number: 37258
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Simon Glass sjg@chromium.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 01 Dec 2019 09:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Simon Glass sjg@chromium.org
Comment-In-Reply-To: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-MessageType: comment