Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/69462
to review the following change.
Change subject: soc/amd/common: Definition of EFS_OFFSET ......................................................................
soc/amd/common: Definition of EFS_OFFSET
The old definition is based on the assumption flash size is 16M bytes. The value is below. 0 Address 0xFA0000 1 Address 0xF20000 2 Address 0xE20000 3 Address 0xC20000 4 Address 0x820000 5 Address 0x20000 But if the flash size is 8M, the EFS address would be 0xff820000, whose relative address is 0x20000.
Change-Id: I915c43d38c09fbb5c7835f139d0c1a4e8526aeec Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/include/amdblocks/psp_efs.h 1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/69462/1
diff --git a/src/soc/amd/common/block/include/amdblocks/psp_efs.h b/src/soc/amd/common/block/include/amdblocks/psp_efs.h index 51b06a6..3e8399f 100644 --- a/src/soc/amd/common/block/include/amdblocks/psp_efs.h +++ b/src/soc/amd/common/block/include/amdblocks/psp_efs.h @@ -5,8 +5,9 @@ #define AMD_COMMON_PSP_EFS_H
#include <types.h> +#include <fmap_config.h>
-#define EFS_OFFSET (0xffffff - (0x80000 << CONFIG_AMD_FWM_POSITION_INDEX) + 0x20000 + 1) +#define EFS_OFFSET ((0xffffff - (0x80000 << CONFIG_AMD_FWM_POSITION_INDEX) + 0x20000 + 1) - (FMAP_SECTION_FLASH_START & 0xffffff))
#define EMBEDDED_FW_SIGNATURE 0x55aa55aa