[coreboot-gerrit] Change in coreboot[master]: soc/intel: Add Intel Xeon Scalable Processor support

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )

Change subject: soc/intel: Add Intel Xeon Scalable Processor support
......................................................................

Patch Set 45: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38548/45/src/soc/intel/xeon_sp/incl... 
File src/soc/intel/xeon_sp/include/soc/romstage.h:

https://review.coreboot.org/c/coreboot/+/38548/45/src/soc/intel/xeon_sp/incl... 
PS45, Line 25: void
I don't think mainboard_config_gpios() is called directly outside of the mainboard's own romstage.c file, so you should not need to define it here.

However, if for some reason you do need it here then the argument needs to be `FSPM_UPD *mupd` to work with the declaration in the mainboard's romstage.c (in the follow-up patch).