[coreboot-gerrit] Change in coreboot[master]: mainboard: Add Lenovo ThinkPad T440p

[Iru Cai (vimacs) (Code Review)]

Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )

Change subject: mainboard: Add Lenovo ThinkPad T440p
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@26 
PS3, Line 26: - The Fn key is on by default
The Fn key issue can be resolved by (in the OEM firmware it uses 0x1604/0x1600, but 0x66/0x62 should be ok):

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index 2b959ceea1..118bd69d88 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -80,10 +80,10 @@ static void h8_charge_priority(enum battery battery)

static void h8_sticky_fn(int on)
 {
-       if (on)
-               ec_set_bit(0x0, 3);
+       if (!on)
+               ec_set_bit(0x3b, 3);
        else
-               ec_clr_bit(0x0, 3);
+               ec_clr_bit(0x3b, 3);
 }