Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons.
Utkarsh Verma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 )
Change subject: arch/x86/smbios: Avoid buffer overflows
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74128/comment/441c9605_56779b3a
PS3, Line 9: The format specifiers for numbers in snprintf() calls are updated to be
The checkpatch comments are unfortunately added to the wrong line and refer to the line below, which […]
Done
https://review.coreboot.org/c/coreboot/+/74128/comment/3c503b76_d24780a2
PS3, Line 21:
The blank line could be removed.
Done
Patchset:
PS4:
I hope this fixes it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74128
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbf93fd113791b6faa1e5128da8e692f7f00ac73
Gerrit-Change-Number: 74128
Gerrit-PatchSet: 4
Gerrit-Owner: Utkarsh Verma
utkarsh@bitbanged.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 02 Apr 2023 14:43:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Utkarsh Verma
utkarsh@bitbanged.com
Gerrit-MessageType: comment