Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Make stage cache kconfig selection proper
......................................................................
Patch Set 18:
And kconfig is not just disappearing its been replaced with some code which might not meet your requirement, i want to understand that.
I am only critisizing the silent removal of 'RELOCATABLE_RAMSTAGE'. It is a pretty fundamental Kconfig. Sure, you are replacing it, but there is no mention of doing so in the commit message.
There was some chance of this being merged just before 4.10 release, thus my -2. I don't have proper understanding about possible new stage cache requirements triggering this particular commit.
As a background info, I believe I am the one who brought most of pre-Haswell Intels and AGESA/binaryPI AMD CPUs all the way through STATIC_CBMEM, DYNAMIC_CBMEM, EARLY_CBMEM_INIT, RELOCATABLE_RAMSTAGE and finally POSTCAR_STAGE phases. I guess I should know, but is there something fundamentally wrong with the name 'RELOCATABLE_RAMSTAGE'? We have had it for maybe six years like that. And from day one, it has implied parts other than the ramstage are also relocatable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 18
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jul 2019 09:05:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment