Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32713 )
Change subject: util/inteltool: Use appropriate channel for printing timings
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32713/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32713/1//COMMIT_MSG@7
PS1, Line 7: util/inteltool: Error if first channel is not found
Please make this a statement by adding a verb (in imperative mood). […]
Done
https://review.coreboot.org/#/c/32713/1//COMMIT_MSG@9
PS1, Line 9: The first channel is needed to initialize the timing
: arrays. If it is not present there will be undefined
: reads in the 'print_time' function calls starting on
: line 182.
Please use the fully allowed text width.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b59989242e498474782876302e0850e3e4cf2d3
Gerrit-Change-Number: 32713
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 May 2019 23:53:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment