Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32447 )
Change subject: soc/intel/common: Add support to clear GPI IS & IE registers ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32447/1/src/soc/intel/common/block/gpio/gpio... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/#/c/32447/1/src/soc/intel/common/block/gpio/gpio... PS1, Line 598: comm->gpi_int_en_reg_0 + : group * sizeof(uint32_t) nit: You can also create macros like GPI_IE_OFFSET and GPI_IS_OFFSET similar to GPI_SMI_STS_OFFSET and GPI_SMI_EN_OFFSET
https://review.coreboot.org/#/c/32447/1/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/gpio.h:
https://review.coreboot.org/#/c/32447/1/src/soc/intel/common/block/include/i... PS1, Line 216: gpi_clear_int_cfg Probably name this gpio_clear_int_cfg() to match the rest of the function APIs?