[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Boot up SSPM

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )

Change subject: google/kukui: Boot up SSPM
......................................................................

Patch Set 7: Code-Review+2

(1 comment)

LGTM, but you'll need to submit the binary to blobs.git first, obviously.

https://review.coreboot.org/#/c/31516/7/src/soc/mediatek/mt8183/sspm.c 
File src/soc/mediatek/mt8183/sspm.c:

https://review.coreboot.org/#/c/31516/7/src/soc/mediatek/mt8183/sspm.c@24 
PS7, Line 24: static uint8_t sspm_bin[BUF_SIZE];
nit: I don't exactly remember the default alignment rules in effect here, but you may wanna add an __aligned(8) here just to make sure it will always be well-aligned (because the compiler just sees uint8_t with a 1-byte alignment requirement here).