Attention is currently required from: Tarun Tuli, Martin L Roth, Eran Mitrani, Nick Vaccaro.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69970 )
Change subject: {soc/intel/cmn/pcie, mb/google/volteer}: Rename `is_external` variable
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69970/comment/f60d3592_d46e3723
PS2, Line 7: {soc/intel/cmn/pcie, mb/google/volteer}: Rename `is_external` to `add_acpi_external_facing_port`
Please shorten to under 65 characters.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69970
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65100283ed9b65037c9890f28ecab41fcfa25d83
Gerrit-Change-Number: 69970
Gerrit-PatchSet: 3
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 28 Nov 2022 04:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment