Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38926 )
Change subject: Documentation: Add GM45 ThinkPads common page ......................................................................
Patch Set 8:
(11 comments)
https://review.coreboot.org/c/coreboot/+/38926/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38926/6//COMMIT_MSG@9 PS6, Line 9: - Add a common page about GM45 ThinkPads. : - Describe how to disable ME and remove it's firmware : on these models. : - Describe default flash layouts. : : Thanks to swiftgeek for his help when writing this, : especially the last paragraph and flash layouts.
If in doubt, gerrit's UI allows editing a commit message, and the default box size is a good referen […]
Done
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... File Documentation/mainboard/lenovo/montevina_series.md:
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 3: MB
flash chip sizes are multiples of 1024, not 1000: s/MB/MiB/g
Done
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 4: chip in your machine through flashrom:
Note that this does not allow you to determine whether the chip is in a SOIC-8 or a SOIC-16 package.
Sounds good.
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 18: make
make*s*
Done
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 26: Your
You
Done
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 26: Then extract FD modules to a separate files
I would reword this a bit: […]
Done
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 78: Creating new
Creating *a* new
Done
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 80: generate modified
generate *a* modified
Done
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 129: touch other
touch *any* other
Done
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 129: with flash
with *the* flash […]
Done
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/len... File Documentation/mainboard/lenovo/xx00_series.md:
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/len... PS4, Line 1: T400
That a device has a dGPU does not necessarily mean that the firmware descriptor changes. […]
Done