4 Feb
2020
4 Feb
'20
11:33 p.m.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38706 )
Change subject: security/vboot: relocate vb2ex_abort and vb2ex_printf ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38706/4/src/security/vboot/vboot_co... File src/security/vboot/vboot_common.c:
https://review.coreboot.org/c/coreboot/+/38706/4/src/security/vboot/vboot_co... PS4, Line 29: #if CONFIG(VBOOT)
This is to match the CONFIG(VBOOT) conditional in vboot_common.h. […]
Oh. Because of the different definitions and guards. I see. I just assumed if it wasn't used it wouldn't be linked in. nm.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38706
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica0103c5684b3d50ba7dc1b4c39559cb192efa81
Gerrit-Change-Number: 38706
Gerrit-PatchSet: 4
Gerrit-Owner: Joel Kitching kitching@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Frans Hendriks fhendriks@eltan.com
Gerrit-Comment-Date: Tue, 04 Feb 2020 22:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Comment-In-Reply-To: Joel Kitching kitching@google.com
Gerrit-MessageType: comment