Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33799 )
Change subject: src/lib/hexdump: Use size_t for indices
......................................................................
Patch Set 8: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/33799/3/src/lib/hexdump.c
File src/lib/hexdump.c:
https://review.coreboot.org/c/coreboot/+/33799/3/src/lib/hexdump.c@26
PS3, Line 26: int j, num_bytes
It's probably better to have them both as size_t, since otherwise there will be a size_t -> int conv […]
Done
https://review.coreboot.org/c/coreboot/+/33799/6/src/lib/hexdump.c
File src/lib/hexdump.c:
https://review.coreboot.org/c/coreboot/+/33799/6/src/lib/hexdump.c@67
PS6, Line 67: int
I suppose the argument could be made that since its value at the end of the while loop will be the o […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29a7ae8c499bb1e8ab7c8741b2dfb7663d82a362
Gerrit-Change-Number: 33799
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 22 Jul 2019 02:11:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment