Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30850 )
Change subject: mb/emulation/qemu-i440fx: use e820 in romstage
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/30850/5/src/mainboard/emulation/qemu-i440fx/...
File src/mainboard/emulation/qemu-i440fx/memory.c:
https://review.coreboot.org/#/c/30850/5/src/mainboard/emulation/qemu-i440fx/...
PS5, Line 20: #include "fw_cfg_if.h"
is fw_cfg_if.h needed here ? looks like fw_cfg.h already includes it.
https://review.coreboot.org/#/c/30850/5/src/mainboard/emulation/qemu-i440fx/...
PS5, Line 57: unsigned long tom = 0;
please use uintptr_t
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6465085020125fc790257f09eb157030c6ceabcb
Gerrit-Change-Number: 30850
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Jan 2019 07:37:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment