Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42199 )
Change subject: soc/intel/cannonlake: Make `acpi_create_gnvs()` static ......................................................................
soc/intel/cannonlake: Make `acpi_create_gnvs()` static
The function `acpi_create_gnvs()` is only used in this translation unit, so make it `static`. This unifies it with the Skylake version `src/soc/intel/skylake/acpi.c`.
Change-Id: I8f817aa46c75332ec5a5fa77e8772ae0f0e3a366 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/soc/intel/cannonlake/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/42199/1
diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c index 12758e1..886cba2 100644 --- a/src/soc/intel/cannonlake/acpi.c +++ b/src/soc/intel/cannonlake/acpi.c @@ -182,7 +182,7 @@ return read32((void *)pmc_bar + IRQ_REG); }
-void acpi_create_gnvs(struct global_nvs_t *gnvs) +static void acpi_create_gnvs(struct global_nvs_t *gnvs) { const struct soc_intel_cannonlake_config *config; config = config_of_soc();