Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: src/mainboard/asus: Add H110M-E/M.2 mainboard support ......................................................................
Patch Set 18:
(1 comment)
Good luck :)
Thank you very much :)
https://review.coreboot.org/c/coreboot/+/34603/18/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/18/src/mainboard/asus/h110m-e... PS18, Line 278: device pci 14.2 on # Thermal Subsystem : subsystemid 0x1849 0xa131 : end
I checked the lspci with vendor BIOS for that board and it is reported as disabled. […]
Maybe this can be enabled/disabled in the BIOS settings?
According to the documentation, the PCH Thermal Subsystem incorporates an on-die Digital Thermal Sensor for thermal management. This device may cause interruptions or shut down the system to S5 with a programmable catastrophic trip point:
https://github.com/coreboot/coreboot/blob/205d5ab20842e57ffd90b78e9d71db7e58... https://github.com/coreboot/coreboot/blob/8950cfb66f8f1fd4b047fbef2347134be0...
In addition, the coreboot uses this device for DPTF: https://github.com/coreboot/coreboot/blob/4f16049f17a4dcbf329d6b30f0d00f0a7f...
I think it would be better to enable device pci 14.2