Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/38239 )
Change subject: gma: Split `Internal` port type into `eDP` & `LVDS` ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/38239/1/common/hw-gfx-gma-config_... File common/hw-gfx-gma-config_helpers.adb:
https://review.coreboot.org/c/libgfxinit/+/38239/1/common/hw-gfx-gma-config_... PS1, Line 65: PCH_LVDS
Seems odd, does it matter?
It shouldn't. Before this change, we had to guarantee that we don't call this with `Internal && Internal_Is_eDP`. Now we have to guarantee that we don't call this with `eDP`. The assumptions stay the same.
However, we could add a precondition for this. Don't know how deep the rabbit hole goes, though, i.e. if it would be hard to prove.