[coreboot-gerrit] Change in ...coreboot[master]: vboot: refactor OPROM code

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )

Change subject: vboot: refactor OPROM code
......................................................................

Patch Set 7: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/32262/6/src/security/vboot/misc.h 
File src/security/vboot/misc.h:

https://review.coreboot.org/#/c/32262/6/src/security/vboot/misc.h@40 
PS6, Line 40: 	uint32_t buffer_size;
> Okay, I see what you're saying. […]

I don't remember the exact rules in the standard, but for the compilers we use (GCC/clang) you can generally assume that they won't add padding as long as all members are already naturally aligned (and that's why we should always make sure that's the case in all serialized structures, adding explicit 'u8 reserved' members if needed... the other option is using __packed, but that comes bundled with some stupid other effects we don't want so it's better to avoid it where possible).