Siyuan Wang (wangsiyuanbuaa@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3852
-gerrit
commit 80013e6fd2f1532fa151f106afbc67772dbe4cb5 Author: Siyuan Wang wangsiyuanbuaa@gmail.com Date: Fri Aug 9 18:18:30 2013 +0800
remove unused code in src/cpu/amd/agesa/cache_as_ram.inc
'invd' in disable_cache_as_ram could result to boot failure on AMD Olive Hill. This patch has tested on Parmer and Olive Hill.
Change-Id: Ibe9e4105eee032471ccbb2d537471d5fa5847d22 Signed-off-by: Bruce Griffith bruce.griffith@se-eng.com Signed-off-by: Siyuan Wang SiYuan.Wang@amd.com Signed-off-by: Siyuan Wang wangsiyuanbuaa@gmail.com --- src/cpu/amd/agesa/cache_as_ram.inc | 13 ------------- 1 file changed, 13 deletions(-)
diff --git a/src/cpu/amd/agesa/cache_as_ram.inc b/src/cpu/amd/agesa/cache_as_ram.inc index c645a1e..3537c38 100755 --- a/src/cpu/amd/agesa/cache_as_ram.inc +++ b/src/cpu/amd/agesa/cache_as_ram.inc @@ -87,21 +87,8 @@ disable_cache_as_ram: /* Save return stack */ movd %esp, %xmm0
- /* Disable cache */ - movl %cr0, %eax - orl $CR0_CacheDisable, %eax - movl %eax, %cr0 - - invd - AMD_DISABLE_STACK
- /* enable cache */ - movl %cr0, %eax - andl $0x9fffffff, %eax - movl %eax, %cr0 - xorl %eax, %eax - /* Restore the return stack */ movd %xmm0, %esp ret