Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33782 )
Change subject: vbe.h: Convert hardcode vesa mode into macro ......................................................................
Patch Set 4: Code-Review-1
(2 comments)
https://review.coreboot.org/#/c/33782/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33782/4//COMMIT_MSG@12 PS4, Line 12: Also make use of __packed attribute in vbe_info_t structure. Please split this change off. This is the major change in this patch but does not look like that from the commit message.
https://review.coreboot.org/#/c/33782/1/src/include/vbe.h File src/include/vbe.h:
https://review.coreboot.org/#/c/33782/1/src/include/vbe.h@48 PS1, Line 48: u16 video_mode_list[MAX_VBE_FRAMEBUFFER_MODE]; This struct does not map to the return value of the VBEINFO INT, which just returns a pointer. If you you memcpy the return value buffer into this struct, the total_memory value is not correct. It's also does seem not very portable either. I'd just decode the return buffer like done in device/oprom/yabel/vbe.c\090:vbe_info(vbe_info_t * info)