Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a...
File src/soc/intel/common/acpi/platform.asl:
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a...
PS2, Line 41: /* Call EC _PTS handler */
: _SB.PCI0.LPCB.EC0.PTS (Arg0)
I wonder if we should move this into the new MPTS/MWAK too, since that is where the EC is hooked up.
https://review.coreboot.org/c/coreboot/+/32371 , or move into MPTS/MWAK is also fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32366
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie63711748b6dbb99d34910824f2059464543e162
Gerrit-Change-Number: 32366
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 20 Apr 2019 03:38:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment