build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45192 )
Change subject: soc/intel/alderlake/romstage: Do initial SoC commit till romstage ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45192/3/src/soc/intel/alderlake/chi... File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/45192/3/src/soc/intel/alderlake/chi... PS3, Line 321: * Thats the reason FSP skips cpu_ratio override if cpu_ratio is 0. 'Thats' may be misspelled - perhaps 'That's'?
https://review.coreboot.org/c/coreboot/+/45192/3/src/soc/intel/alderlake/mem... File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/45192/3/src/soc/intel/alderlake/mem... PS3, Line 182: memset (&mem_cfg->SpdAddressTable, 0, sizeof(mem_cfg->SpdAddressTable)); space prohibited between function name and open parenthesis '('