Attention is currently required from: Angel Pons.
Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54376 )
Change subject: mb/asus/p8h61-m_lx/devicetree.cb: Rewrite number in hex
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
I think decimal is easier to reason about for this value: one can readily
confirm that the value is > 100, so C2 is not supported, or see the real
value in microseconds otherwise. But it's not a big deal and worrying about
it shouldn't slow down real progress, so I have no problem with hex.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54376
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I440706f6fa11d3c2410c445cb7e946c063578c4e
Gerrit-Change-Number: 54376
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 18 May 2021 10:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment