Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42986 )
Change subject: b/google/vilboz: update GPIOs, enable touchpad and wifi module ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42986/6/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:
PS6:
board version is 1.
In that case, VARIANT_MIN_BOARD_ID_V3_SCHEMATICS needs to be set as 1 for Vilboz and VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW needs to be set as 2 (I think current version of hardware does not have active low wifi power enable).
Basically, something like this should work: ``` diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index e24f78a48a5..19225d73024 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -142,13 +142,13 @@ config VARIANT_MIN_BOARD_ID_V3_SCHEMATICS default 3 if BOARD_GOOGLE_MORPHIUS default 2 if BOARD_GOOGLE_BERKNIP default 3 if BOARD_GOOGLE_DALBOZ - default 2 if BOARD_GOOGLE_VILBOZ + default 1 if BOARD_GOOGLE_VILBOZ default 256
config VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW int default 3 if BOARD_GOOGLE_BERKNIP - default 3 if BOARD_GOOGLE_VILBOZ + default 2 if BOARD_GOOGLE_VILBOZ default VARIANT_MIN_BOARD_ID_V3_SCHEMATICS
endif # BOARD_GOOGLE_BASEBOARD_TREMBYLE || BOARD_GOOGLE_BASEBOARD_DALBOZ ```