Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38010 )
Change subject: nb/intel/sandybridge: add and use more MCHBAR register defines ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/sandybridge.h:
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... PS1, Line 135: PM_PDWN_Config
CB:38028
Done
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... PS1, Line 141: 0x5d14
I thought this was 0x5d10 ?
yeah, i also wondered why 0x5d14 is used here. maybe to just use a part of the 64 bit register?! since I don't have hardware to test with me at the moment, I only did some cleanups that don't change the binary output